Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-git-grep-skip-counting-lines): New defcustom #1042

Closed
wants to merge 1 commit into from

Conversation

@edkolev
Copy link
Contributor

@edkolev edkolev commented Jun 2, 2017

Refs #524

@edkolev
Copy link
Contributor Author

@edkolev edkolev commented Jun 2, 2017

As discussed in #524.

Let me know in case the PR can be improved.

@edkolev edkolev force-pushed the edkolev:skip-count-lines branch 2 times, most recently Jun 2, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 3, 2017

There's a problem: when counsel-git-grep-skip-counting-lines is non-nil, shell-command-to-string gets called: it is sync so you wait for all results before you can enter a new key. counsel--gg-candidates should be called to get candidates async.

@edkolev
Copy link
Contributor Author

@edkolev edkolev commented Jun 5, 2017

Thanks for catching this! I modified counsel-git-grep-function to call the async counsel--gg-candidates.

For testing purposes, I simulated a slow git command with: counsel-git-grep-cmd-default set to "sleep 2 && git --no-pager grep --full-name -n --no-color -i -e '%s'"

The commit is amended. Again, let me know if I can improve anything.

@edkolev edkolev force-pushed the edkolev:skip-count-lines branch to effd323 Jun 5, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 5, 2017

Thanks. It seems you don't yet have an Emacs CA. And your cumulative contributions are above the 15 line limit where you don't need it. See README on more info on getting an Emacs Copyright Assignment.

@edkolev
Copy link
Contributor Author

@edkolev edkolev commented Jun 6, 2017

Thanks, I sent the initial email, I'll write here when I get the CA.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 6, 2017

Thanks.

@edkolev
Copy link
Contributor Author

@edkolev edkolev commented Jun 8, 2017

Hi, I now have a signed (by me & FSF) CA in digital format.

@abo-abo abo-abo closed this in 1cab926 Jun 9, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 9, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants