New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-yank-pop): ignore entirely empty candidates #1043

Merged
merged 1 commit into from Jun 3, 2017

Conversation

Projects
None yet
2 participants
@braham-snyder
Contributor

braham-snyder commented Jun 3, 2017

  • whose most noticeable effect -- when present in kill-ring and
    not ignored here -- is their preselection upon every new call to
    counsel-yank-pop (since they exactly match an empty initial
    input); empty initial input could perhaps be special-cased w/r/t
    preselection, but, regardless:

  • pasting an entirely empty string is a no-op, so counsel-yank-pop
    should likely exclude such candidates (are entirely empty strings
    ever useful ivy candidates?)

counsel.el (counsel-yank-pop): ignore entirely empty candidates
* whose most noticeable effect -- when present in `kill-ring' and
  not ignored here -- is their preselection upon every new call to
  `counsel-yank-pop' (since they exactly match an empty initial
  input); empty initial input could perhaps be special-cased w/r/t
  preselection, but, regardless:

* pasting an entirely empty string is a no-op, so `counsel-yank-pop'
  should likely exclude such candidates (are entirely empty strings
  ever useful ivy candidates?)

@abo-abo abo-abo merged commit 9515770 into abo-abo:master Jun 3, 2017

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Owner

abo-abo commented Jun 3, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment