New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop counsel-ag-occur from breaking when search string begins with "-" #1048

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@purcell
Contributor

purcell commented Jun 5, 2017

Just a small fix for an issue I encountered. :-)

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Jun 5, 2017

Wouldn't it be better to modify counsel-ag-base-command (add "-- " at the end)? That way, it's more user-customizable, less hard-coding. Or is "-- " always useful?

@purcell

This comment has been minimized.

Contributor

purcell commented Jun 5, 2017

Yep, maybe. I found some handling of -- elsewhere in the code, and in fact counsel-ag works fine even with those search strings. The tricky thing was that counsel-ag supports other custom args, so I wasn't sure exactly where to insert the --.

@abo-abo abo-abo closed this in 2d29191 Jun 5, 2017

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Jun 5, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment