Repository navigation
Cleanup/counsel file register - #1066
Merged
Merged
Conversation
The recent patch introducing `counsel-file-register' has a few typos and mistakes such as pointlessly repeated keywords. This patch makes no changes to logic but fixes those types and removes duplicate keywords in `counsel-file-register'. This patch also improves the docstring for `counsel-file-register` to mention how you *must* use `set-register' to create file registers. Signed-off-by: Eric James Michael Ritz <ericjmritz@yandex.com>
This patch adds an additional action to `counsel-file-register', bound to the `j' key, so that users may press `M-o j' to view file registers in different windows. The default action remains to open the file in the window from which we called `counsel-file-register'. Signed-off-by: Eric James Michael Ritz <ericjmritz@yandex.com>
Owner
|
Thanks. |
Contributor
Author
|
Thanks again for the merge. I've used register for a long time but very often for file registers. However, I am starting to use registers for their other possible purposes so in the future I may be preserting some more PRs to define |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original pull-request had some mistakes such as accidentally using certain keywords to
ivy-readmore than once. This series of two patches both correct that problem and useivy-set-actionsto make it possible to open a file register in another window.