Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/counsel file register #1066

Merged
merged 2 commits into from Jun 10, 2017
Merged

Cleanup/counsel file register #1066

merged 2 commits into from Jun 10, 2017

Conversation

@ejmr
Copy link
Contributor

@ejmr ejmr commented Jun 10, 2017

The original pull-request had some mistakes such as accidentally using certain keywords to ivy-read more than once. This series of two patches both correct that problem and use ivy-set-actions to make it possible to open a file register in another window.

ejmr added 2 commits Jun 10, 2017
The recent patch introducing `counsel-file-register' has a few typos
and mistakes such as pointlessly repeated keywords.  This patch makes
no changes to logic but fixes those types and removes duplicate
keywords in `counsel-file-register'.  This patch also improves the
docstring for `counsel-file-register` to mention how you *must* use
`set-register' to create file registers.

Signed-off-by: Eric James Michael Ritz <ericjmritz@yandex.com>
This patch adds an additional action to `counsel-file-register', bound
to the `j' key, so that users may press `M-o j' to view file registers
in different windows.  The default action remains to open the file in
the window from which we called `counsel-file-register'.

Signed-off-by: Eric James Michael Ritz <ericjmritz@yandex.com>
@abo-abo abo-abo merged commit 693f55d into abo-abo:master Jun 10, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 10, 2017

Thanks.

@ejmr
Copy link
Contributor Author

@ejmr ejmr commented Jun 10, 2017

Thanks again for the merge. I've used register for a long time but very often for file registers. However, I am starting to use registers for their other possible purposes so in the future I may be preserting some more PRs to define counsel-* commands for them.

@ejmr ejmr deleted the ejmr:cleanup/counsel-file-register branch Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants