Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-M-x): Don't rebuild cache on every invocation. #1085

Merged
merged 1 commit into from Jun 28, 2017

Conversation

@rudolfochrist
Copy link
Contributor

@rudolfochrist rudolfochrist commented Jun 28, 2017

counsel-M-x is really slow for me and I think it has something to do with the rebuild of the smex-ido-cache which happens on each invocation of counsel-M-x.

By guarding the cache rebuilding only if new commands are detected we can increase the speed of counsel-M-x subsequent invocations.

Thanks (and keep up the awesome work!)

The `smex-ido-cache' needs only be rebuild when new commands has been
detected. So, check first if new commands available and then update
smex.

This should speed up sequential invocations of `counsel-M-x'.
@abo-abo abo-abo merged commit e9bb583 into abo-abo:master Jun 28, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 28, 2017

By guarding the cache rebuilding only if new commands are detected we can increase the speed of counsel-M-x subsequent invocations.

Thanks.

Thanks (and keep up the awesome work!)

Glad to help.

@rudolfochrist rudolfochrist deleted the rudolfochrist:counsel-m-x-speed branch Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants