Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counsel-up-level command #1096

Closed
wants to merge 1 commit into from
Closed

Add counsel-up-level command #1096

wants to merge 1 commit into from

Conversation

@czipperz
Copy link
Contributor

@czipperz czipperz commented Jul 5, 2017

This is the equivalent of helm's C-l.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 5, 2017

How is this different from counsel-up-directory (bound to C-<backspace>)?

@czipperz
Copy link
Contributor Author

@czipperz czipperz commented Jul 5, 2017

I have rebound counsel-up-directory to counsel-up-level in my config because I think it is more useful.

;; counsel-up-directory
/a/long/path/x => /a/long/
/a/long/path/ => /a/long/

;; counsel-up-level
/a/long/path/x => /a/long/path/
/a/long/path/ => /a/long/

@czipperz
Copy link
Contributor Author

@czipperz czipperz commented Jul 6, 2017

This is similar to ivy-backward-kill-word when backward kill word is called at the end of the prompt line.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 6, 2017

I think I like counsel-up-level behavior more. Could you please rework your change as a custom variable that makes counsel-up-directory behave as counsel-up-level? Make the variable on by default, and when it's off, the behavior of counsel-up-directory will be the same as now.

Also, I don't see your email in the Emacs Copyright Assignment list. The CA is needed for changes over 15 lines. See README for more info.

@czipperz
Copy link
Contributor Author

@czipperz czipperz commented Jul 6, 2017

I have already filled out a copyright assignment previously. I could send you the pdf of it, already signed by John Hsieh on January 18, 2017

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 6, 2017

I don't see it yet on copyright.list. Could you please ask the copyright clerk to make sure you're there? Also configure git so that at least the commit email matches the on the CA.

@@ -1588,14 +1588,29 @@ When INITIAL-INPUT is non-nil, use it in the minibuffer during completion."
:keymap counsel-find-file-map
:caller 'counsel-find-file))

(defvar counsel-up-directory-level t
Copy link

@kljohann kljohann Jul 9, 2017

Could you make this a defcustom with :type 'boolean and :group 'ivy?

counsel.el Outdated Show resolved Hide resolved
@CeleritasCelery
Copy link
Contributor

@CeleritasCelery CeleritasCelery commented Mar 28, 2019

@czipperz have you managed to get copyright assignment yet? I would love to see this merged.

@czipperz
Copy link
Contributor Author

@czipperz czipperz commented Jun 1, 2019

Ok I'm on the list now.

@czipperz
Copy link
Contributor Author

@czipperz czipperz commented Jun 1, 2019

Okay I rebased it.

@czipperz
Copy link
Contributor Author

@czipperz czipperz commented Jun 1, 2019

Locally (emacs 26.2) test counsel-find-file-with-dotfiles fails at bottom of ivy-test.el. Does anyone know why the first test expects tests/find-file/dotfiles/foo/? It doesn't make much sense to me.

@czipperz
Copy link
Contributor Author

@czipperz czipperz commented Jun 1, 2019

(it fails on abo-abo/master as well as czipperz/master)

@CeleritasCelery
Copy link
Contributor

@CeleritasCelery CeleritasCelery commented Jun 3, 2019

looks like that has been removed from CI for now. LGTM

@abo-abo abo-abo closed this in 92d5335 Jun 4, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 4, 2019

Merged, thanks.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants