Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ivy-previous-line-or-history behaviour on non-initial result #1137

Merged
merged 1 commit into from Aug 4, 2017

Conversation

@purcell
Copy link
Contributor

@purcell purcell commented Aug 4, 2017

ivy-previous-line-or-history should not insert the last history item unless the currently-selected completion candidate is the first in the list, otherwise it's impossible to navigate back up with successive applications of this command.

See purcell/emacs.d#473

ivy-previous-line-or-history should not insert the last history item unless the currently-selected completion candidate is the first in the list, otherwise it's impossible to navigate back up with successive applications of this command.

See purcell/emacs.d#473
@abo-abo abo-abo merged commit abc65d3 into abo-abo:master Aug 4, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 4, 2017

Thanks.

jrosdahl added a commit to jrosdahl/swiper that referenced this pull request Jul 14, 2019
Fixes abo-abo#2137.

Note also that this reverts the fix in abo-abo#1137.
abo-abo added a commit that referenced this pull request Jul 15, 2019
Fixes #2137
Fixes #2138

Note also that this reverts the fix in #1137.
astoff added a commit to astoff/swiper that referenced this pull request Jan 1, 2021
Fixes abo-abo#2137
Fixes abo-abo#2138

Note also that this reverts the fix in abo-abo#1137.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants