New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el (ivy--virtual-buffers): Ensure bookmarks are loaded #1160

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@juergenhoetzel
Contributor

juergenhoetzel commented Aug 14, 2017

Also don't use internal bookmark data structures: The file format
might change again.

I wondered why I couldn't use my bookmarks unless I used some of `bookmark interactive functions directly.

ivy.el (ivy--virtual-buffers): Ensure bookmarks are loaded
Also don't use internal bookmark data structures: The file format
might change again.
@abo-abo

This comment has been minimized.

Owner

abo-abo commented Aug 14, 2017

This commit removes the functionality for file-less bookmarks. Can you add it back?

@juergenhoetzel

This comment has been minimized.

Contributor

juergenhoetzel commented Aug 14, 2017

This commit removes the functionality for file-less bookmarks. Can you add it back?

Sorry, Maybe I got it wrong: To me it seems this was just a safety check to PREVENT collecting file-less bookmarks.
For me this check is not needed anymore since this Emacs commit:

Add a new field `location' to bookmarks for non-file bookmarks

@abo-abo abo-abo merged commit 236021d into abo-abo:master Aug 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Owner

abo-abo commented Aug 14, 2017

You're right, to prevent:). Updated and merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment