New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXED: counsel-git-grep-occur output nothing when negative pattern ex… #1173

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@redguardtoo
Contributor

redguardtoo commented Aug 24, 2017

issue description: M-x counsel-git-grep, input keyword1 !keyword2, then press C-c C-o, always got zero candidates.

This patch fixed the issue, tested on following use cases:

  • !keyword1 keyword2
  • keyword1 !keyword2 keyword3
  • keyword1 !keyword2\|keyword3

@abo-abo abo-abo closed this Sep 11, 2017

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Sep 11, 2017

Thanks. I rewrote your code quite a bit, since it was repeating some of the ivy--regex-function logic. Please check if it still works for you (I checked for one class of input, see commit message).

abo-abo added a commit that referenced this pull request Sep 11, 2017

counsel.el (counsel-git-grep-occur): Fix output with negative pattern
Fixes #1173

Example pattern in this repo: "more in!one di".
@redguardtoo

This comment has been minimized.

Contributor

redguardtoo commented Sep 12, 2017

Good news and bad news.

Good news is the occur itself works correctly.

Bad news is counsel-git-grep is buggy when inserting negative patterns (it used to work when I submit the pull request. Please note then ONLY counsel-git-grep supports negative pattern while counsel-grep, counsel-ag, counsel-rg does NOT. Now even counsel-git-grep fails on negative pattern). Either zero candidates is displayed or the ivy UI stops to respond. Test with the latest version.

Do you want me to create a new issue to track this?

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Sep 12, 2017

Do you want me to create a new issue to track this?

Yes please.

@redguardtoo

This comment has been minimized.

Contributor

redguardtoo commented Sep 13, 2017

created. #1199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment