ivy.el (ivy-next-line): Fix wraparound at end of candidates #118
Conversation
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The
whenclause previously ran even when the updatedivy-indexwas the proper last candidate(1- ivy--length). When not wrapping, the code still worked, sinceivy-indexis explicitly set again. Withivy-wrapt, the choice was immediately set to the first candidate, so you could not reach the last candidate by going down.Fixed, symmetric to
ivy-previous-line.