Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ivy-magic-root-slash #1232

Closed
wants to merge 1 commit into from
Closed

Add ivy-magic-root-slash #1232

wants to merge 1 commit into from

Conversation

@amosbird
Copy link
Contributor

@amosbird amosbird commented Oct 10, 2017

No description provided.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 10, 2017

This feature will limit the functionality of other features, like /ssh: and /sudo:.

@amosbird
Copy link
Contributor Author

@amosbird amosbird commented Oct 11, 2017

hmm, aren't ssh: and sudo: start with / too? what's the limitation?

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 11, 2017

With ivy, you can open sudo in current directory with C-x C-f /sudo:: C-j. This feature got broken a bit, I fixed it just now. With your change, sudo will only be possible from root directory, so you'd have to navigate all the way back.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 11, 2017

With /ssh:, preserving current directory is not an issue. But until you press C-j, you can still back out of changing your current directory. With your change, you won't be able to.

With the default completion, the full path is editable, so backing out of changing the current dir is not a concern there.

@amosbird
Copy link
Contributor Author

@amosbird amosbird commented Oct 11, 2017

ok, so how about using // as a magic string?

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 11, 2017

ok, so how about using // as a magic string?

That's what's used right now. Is that not the case for you?

@amosbird
Copy link
Contributor Author

@amosbird amosbird commented Oct 11, 2017

Ah, all right. Thanks!

@amosbird amosbird closed this Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants