Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el: Add a generic minibuffer history browser. #1237

Closed
wants to merge 2 commits into from

Conversation

@jeberger
Copy link
Contributor

@jeberger jeberger commented Oct 11, 2017

This supersedes counsel-shell-command-history and counsel-expression-history with a generic counsel-minibuffer-history function that works for all minibuffer situations.

jeberger added 2 commits Oct 11, 2017
This supersedes counsel-shell-command-history and counsel-expression-history
with a generic counsel-minibuffer-history function that works for all
minibuffer situations.
This is probably a good idea performance-wise since it limits the number
of collection updates when the user is typing. However, the main reason
for this change is to work around an Emacs freeze on Windows when the
dynamic collection is generated by an external command (see for example
this bug in helm-ag which also affects counsel-ag and similar commands:
emacsorphanage/helm-ag#188).

Related to #1218 (but only applies for dynamic collections, where the
difference is really noticeable).
Helps with #1198 and #786.
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 12, 2017

Thanks. The changes look good, but it seems you're not on copyright.list. Are you willing to get an Emacs Copyright Assignment?

@jeberger
Copy link
Contributor Author

@jeberger jeberger commented Oct 12, 2017

Sure, how do I go about it?

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Oct 12, 2017

You fill in a form and send it by email. Instructions here: https://github.com/abo-abo/swiper#copyright-assignment.

@jeberger
Copy link
Contributor Author

@jeberger jeberger commented Oct 31, 2017

I just got the confirmation email from the FSF, so I should be on copyright.list shortly if I'm not already.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Nov 1, 2017

I just got the confirmation email from the FSF, so I should be on copyright.list shortly if I'm not already.

Thanks for the update and the effort. You're not there yet, I just checked.

@manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented Nov 10, 2017

Any update on this one? Just curious. :)

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Nov 10, 2017

@jeberger I keep checking copyright.list but you're still not there.
Please ask assign@gnu.org to make sure your email used for this commit is on the list (jeberger at free dot fr).

@jeberger
Copy link
Contributor Author

@jeberger jeberger commented Nov 11, 2017

That is the address I used when communicating with the FSF. I've just written to assign@gnu.org to ask them to check.

@jeberger
Copy link
Contributor Author

@jeberger jeberger commented Nov 13, 2017

Just got an email from assign@gnu.org saying that I am now on copyright.list

@abo-abo abo-abo closed this in 68f5f4e Nov 13, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Nov 13, 2017

The assignment is finally updated, you're the last one on the list currently:) Thanks for the contribution!

ivy-dynamic-exhibit-delay-ms

I've reset it to 0 by default: I could really feel the difference in counsel-grep when it was 500ms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants