counsel.el: Add a generic minibuffer history browser. #1237
Conversation
This supersedes counsel-shell-command-history and counsel-expression-history with a generic counsel-minibuffer-history function that works for all minibuffer situations.
This is probably a good idea performance-wise since it limits the number of collection updates when the user is typing. However, the main reason for this change is to work around an Emacs freeze on Windows when the dynamic collection is generated by an external command (see for example this bug in helm-ag which also affects counsel-ag and similar commands: emacsorphanage/helm-ag#188). Related to abo-abo#1218 (but only applies for dynamic collections, where the difference is really noticeable). Helps with abo-abo#1198 and abo-abo#786.
|
Thanks. The changes look good, but it seems you're not on |
|
Sure, how do I go about it? |
|
You fill in a form and send it by email. Instructions here: https://github.com/abo-abo/swiper#copyright-assignment. |
|
I just got the confirmation email from the FSF, so I should be on |
Thanks for the update and the effort. You're not there yet, I just checked. |
|
Any update on this one? Just curious. :) |
|
@jeberger I keep checking |
|
That is the address I used when communicating with the FSF. I've just written to |
|
Just got an email from |
|
The assignment is finally updated, you're the last one on the list currently:) Thanks for the contribution!
I've reset it to 0 by default: I could really feel the difference in |
This supersedes counsel-shell-command-history and counsel-expression-history with a generic counsel-minibuffer-history function that works for all minibuffer situations.