New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el: Require compile.el faces before use #1264

wants to merge 2 commits into
base: master


None yet
2 participants

basil-conto commented Oct 31, 2017

The first commit avoids Invalid face reference errors and non-propertised results for commands using counsel-git-grep-transformer when the compile library has not yet been loaded. I considered placing require calls wherever these faces are used, but there are several such instances and no clean way of covering them all. I would rather not put the require call in the transformer, for instance.

The second commit optimises the aforementioned transformer ever so slightly.

basil-conto added some commits Oct 31, 2017

counsel.el (counsel-git-grep-transformer): Optimise text props
add-face-text-property is both more flexible and slightly more
performant than set-text-properties on the author's machine.

@abo-abo abo-abo closed this in f3a737d Oct 31, 2017


This comment has been minimized.


abo-abo commented Oct 31, 2017


@basil-conto basil-conto deleted the basil-conto:compile-faces branch Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment