Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor counsel grep tweaks #1290

Closed
wants to merge 4 commits into from
Closed

Conversation

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Nov 17, 2017

User-visible changes:

  • Document the format of counsel-grep-base-command.
  • Do not barf in counsel-grep if counsel-grep-base-command does not contain a %s format specifier immediately preceding a newline character or end-of-string.
  • Detect compressed filenames in counsel-grep-or-swiper even after customising jka-compr-compression-info-list.

The rest of the changes are mostly formatting and logic simplifications (I'll be more than happy to revert any such "simplifications" which come across as style changes). Please see the commit messages for further details.

basil-conto added 4 commits Nov 17, 2017
(counsel-grep-or-swiper): De Morgan.  Do not save result of
jka-compr-build-file-regexp which is based on a defcustom.  Lookup
compressed filenames dynamically via jka-compr-get-compression-info
instead.
(counsel-compressed-file-regex): Delete.
(counsel-grep-base-command): Document format-string arguments.
Canonicalize default grep arguments.
(counsel-grep): Make more flexible and efficient use of
counsel-grep-base-command by using it as a format string instead of
parsing it.
@abo-abo abo-abo closed this in 34fa781 Nov 17, 2017
abo-abo added a commit that referenced this issue Nov 17, 2017
Don't want to put it directly because Emacs complains it's risky.

Re #1290
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Nov 17, 2017

Thanks! It was a bit unclear about the indent rules (it still is, see referenced commit). Basically I prefer to have:

(setq lisp-indent-function 'common-lisp-indent-function)

@basil-conto
Copy link
Collaborator Author

@basil-conto basil-conto commented Nov 18, 2017

Ah, right. Sorry, didn't realise common-lisp-indent-function indented unwind-protect differently. Thanks!

@basil-conto basil-conto mentioned this pull request May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants