Minor counsel grep tweaks #1290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(counsel-grep-or-swiper): De Morgan. Do not save result of jka-compr-build-file-regexp which is based on a defcustom. Lookup compressed filenames dynamically via jka-compr-get-compression-info instead. (counsel-compressed-file-regex): Delete.
(counsel-grep-base-command): Document format-string arguments. Canonicalize default grep arguments. (counsel-grep): Make more flexible and efficient use of counsel-grep-base-command by using it as a format string instead of parsing it.
abo-abo
added a commit
that referenced
this pull request
Nov 17, 2017
Don't want to put it directly because Emacs complains it's risky. Re #1290
|
Thanks! It was a bit unclear about the indent rules (it still is, see referenced commit). Basically I prefer to have: |
|
Ah, right. Sorry, didn't realise |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-visible changes:
counsel-grep-base-command.counsel-grepifcounsel-grep-base-commanddoes not contain a%sformat specifier immediately preceding a newline character or end-of-string.counsel-grep-or-swipereven after customisingjka-compr-compression-info-list.The rest of the changes are mostly formatting and logic simplifications (I'll be more than happy to revert any such "simplifications" which come across as style changes). Please see the commit messages for further details.