Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el (ivy-add-actions): Delete action dups by key #1296

Merged
merged 1 commit into from Nov 20, 2017

Conversation

basil-conto
Copy link
Collaborator

I am not sure whether similar delete-dups calls in ivy-read should be changed as well.

(plist-get ivy--actions-list cmd))))))
(cl-delete-duplicates
(append (plist-get ivy--actions-list cmd) actions)
:key #'car :test #'equal))))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this could also be

(cl-delete-duplicates
 (append actions (plist-get ivy--actions-list cmd))
 :key #'car :test #'equal :from-end t)

but that would be ever so slightly slower.

@abo-abo abo-abo merged commit 7109ce0 into abo-abo:master Nov 20, 2017
@abo-abo
Copy link
Owner

abo-abo commented Nov 20, 2017

Thanks.

@basil-conto basil-conto deleted the action-dups branch November 20, 2017 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants