New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el (ivy-add-actions): Delete action dups by key #1296

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
2 participants
@basil-conto
Contributor

basil-conto commented Nov 20, 2017

I am not sure whether similar delete-dups calls in ivy-read should be changed as well.

(plist-get ivy--actions-list cmd))))))
(cl-delete-duplicates
(append (plist-get ivy--actions-list cmd) actions)
:key #'car :test #'equal))))

This comment has been minimized.

@basil-conto

basil-conto Nov 20, 2017

Contributor

FYI this could also be

(cl-delete-duplicates
 (append actions (plist-get ivy--actions-list cmd))
 :key #'car :test #'equal :from-end t)

but that would be ever so slightly slower.

@abo-abo abo-abo merged commit 7109ce0 into abo-abo:master Nov 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Owner

abo-abo commented Nov 20, 2017

Thanks.

@basil-conto basil-conto deleted the basil-conto:action-dups branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment