ivy-test.el (ivy-with-r): Use with-output-to-string

[basil-conto]

Changelog

• Reuse existing macro logic.
• Reduce side effects by passing non-nil NORECORD arg to switch-to-buffer.
• Consistently quote function symbols as such.

Question

The ivy-completion-in-region test which makes use of this macro emits a "Sole match" message amid make test results. Would it be desirable to bind inhibit-message to t around execute-kbd-macro or elsewhere in ivy-with-r to suppress this message, or would that be a bad idea?

[abo-abo]

Would it be desirable to bind inhibit-message to t around execute-kbd-macro or elsewhere in ivy-with-r to suppress this message, or would that be a bad idea?

As I found out recently, if you bind inhibit-message, you lose out on edebug. Let's keep the message.

[basil-conto]

Fair enough, thanks.