Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-test.el (ivy-with-r): Use with-output-to-string #1300

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@basil-conto
Copy link
Contributor

commented Nov 21, 2017

Changelog

  • Reuse existing macro logic.
  • Reduce side effects by passing non-nil NORECORD arg to switch-to-buffer.
  • Consistently quote function symbols as such.

Question

The ivy-completion-in-region test which makes use of this macro emits a "Sole match" message amid make test results. Would it be desirable to bind inhibit-message to t around execute-kbd-macro or elsewhere in ivy-with-r to suppress this message, or would that be a bad idea?

ivy-test.el (ivy-with-r): Use with-output-to-string
- Reuse existing macro logic.
- Minimise side effects by passing non-nil NORECORD arg to
  switch-to-buffer.
- Consistently quote function symbols as such.

@abo-abo abo-abo closed this in 5c559f5 Nov 21, 2017

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Nov 21, 2017

Would it be desirable to bind inhibit-message to t around execute-kbd-macro or elsewhere in ivy-with-r to suppress this message, or would that be a bad idea?

As I found out recently, if you bind inhibit-message, you lose out on edebug. Let's keep the message.

@basil-conto

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2017

Fair enough, thanks.

@basil-conto basil-conto deleted the basil-conto:ivy-with-r branch Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.