counsel.el (counsel-mark-ring): Improve

[basil-conto]

Changelog

(counsel--pad): Remove unnecessary defun.
(counsel-mark-ring): Support narrowing and ivy-immediate-done.
Fix line number formatting and mark-ring uniquifying and sorting.
Remove redundant call to Emacs 25.1 macro save-mark-and-excursion.
(counsel-mode-map): Replace pop-mark with pop-to-mark-command.

Question before merging

pop-to-mark-command has no default global binding. This means that the user has to explicitly bind a global pop-to-mark-command key in order for the rebinding in counsel-mode-map to counsel-mark-ring to work. Isn't overriding an explicit user key binding The Wrong Thing? Even if deemed acceptable, is there any point in rebinding an unbound command?

[abo-abo]

Thanks.

Isn't overriding an explicit user key binding The Wrong Thing?

I think this was specifically requested by a user as a feature, i.e. enable counsel-mode and have it do all the rebinds possible.

[basil-conto]

I think this was specifically requested by a user as a feature, i.e. enable counsel-mode and have it do all the rebinds possible.

Fair enough, thanks.