Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fboundp and functionp correctly for great good #1336

Merged
merged 1 commit into from Nov 29, 2017

Conversation

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Nov 29, 2017

Changelog

  • counsel.el (counsel-el): Simplify predicate to fboundp.
  • ivy.el (ivy-completion-in-region-action): Use fboundp to make
    feature detection more robust while silencing byte-compiler.
    (ivy-switch-buffer): Commands must satisfy functionp, not fboundp.

Question

(or (functionp x)
    (macrop x)
    (special-form-p x))

Is there some edge case where this is not equivalent to fboundp, at least for our intentions?

* counsel.el (counsel-el): Simplify predicate to fboundp.
* ivy.el (ivy-completion-in-region-action): Use fboundp to make
feature detection more robust while silencing byte-compiler.
(ivy-switch-buffer): Commands must satisfy functionp, not fboundp.
@abo-abo abo-abo merged commit 2393540 into abo-abo:master Nov 29, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Nov 29, 2017

Is there some edge case where this is not equivalent to fboundp, at least for our intentions?

Probably not.

@basil-conto basil-conto deleted the basil-conto:fboundp branch Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants