Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise own and pacify byte-compiler's warnings #1343

Closed
wants to merge 2 commits into from

Conversation

@basil-conto
Copy link
Collaborator

commented Dec 5, 2017

Changelog

  • Reject non-file-visiting buffers in counsel-grep and clarify this in its docstring.
  • Pacify the latest byte-compiler warnings.
basil-conto added 2 commits Dec 5, 2017

@basil-conto basil-conto force-pushed the basil-conto:warnings branch to 104fb5c Dec 5, 2017

@abo-abo abo-abo closed this in a4d7b83 Dec 5, 2017

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Dec 5, 2017

Thanks.

@basil-conto basil-conto deleted the basil-conto:warnings branch Dec 5, 2017

@DamienCassou

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2017

Does that close #1337 too?

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Dec 7, 2017

@DamienCassou I guess so. I mean wgrep is likely restricted to existing files by design. If that's not the case and file-less buffers can be supported by wgrep, support for this can be added to Ivy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.