Preselect current file when showing list of files

[neojski]

Motivation is when you're browsing files in a directory one by one you want an easy way to go to the next one. With this change you only press ctrl-n.
Even without this example seems like a better default compared to ..

This commit also does tiny refactor to remove duplicate code.

[dieggsy]

This should probably be called counsel--preselect-file

[neojski]

Oh, right, fixing.

[dieggsy]

I think it would be good to make this optional in any case.

[neojski]

@dieggsy, I added an option to turn my modification off.

[basil-conto]

This last operand of or can be written as

(and counsel-preselect-current-file
     buffer-file-name
     (file-name-nondirectory buffer-file-name))

Either way, please add a docstring!

[neojski]

Added docstring. I'm not convinced by (and x y z) being more readable but if that's more idiomatic lisp I can change it.

[basil-conto]

My opinion may not count for much, but since we're interested in the final expression's value and not control flow, doubly nested when forms are a big no-no. Please use and, which is not only more idiomatic Elisp but both logically and syntactically simpler.

[neojski]

"big no-no" sounds very serious. I'll change it to and, then. Thanks for adding some motivation as why this is.

[basil-conto]

"big no-no" sounds very serious

I didn't intend for it to sound so serious/harmful, sorry about that. My argument can be summarised as "it's not idiomatic and it's more complex."

[neojski]

No worries :-)
I appreciate your comments and will gladly learn from you.

[basil-conto]

Nitpick: "preselect" instead of "preselects", as this defcustom is not the one performing the preselection.

[neojski]

Fixed below.

[abo-abo]

Thanks, the change looks fine. Just make counsel-preselect-current-file off by default and add some small docstring to the new function.

This change is over 15 lines. Are you willing to get an Emacs Copyright Assignment? See README for more info.

[neojski]

I just sent an email to assign@gnu.org regarding Emacs Copyright Assignement. Do we have to wait until they reply to merge this PR?

[abo-abo]

Do we have to wait until they reply to merge this PR?

Yes, unfortunately. Hopefully, it won't take long. Thanks for the effort.

[neojski]

Ping @abo-abo, I have the Emacs Copyright Assignment now. Can we get this PR merged?

[abo-abo]

Thanks. Could you please resolve the merge conflict and update the PR?

[basil-conto]

How about something like

  "Return candidate to preselect during filename completion.
The preselect behaviour can be customized via user options
`counsel-find-file-at-point' and
`counsel-preselect-current-file', which see."

[basil-conto]

My suggestion is basically to try and follow the conventions listed in (elisp) Documentation Tips.

[neojski]

@basil-conto, @abo-abo, I updated the PR. Thanks!

[abo-abo]

Thanks.