Make counsel-yank-pop ivy-height configurable #1365
Conversation
counsel.el
Outdated
| @@ -3133,6 +3133,11 @@ A is the left hand side, B the right hand side." | |||
| :group 'ivy | |||
| :type 'string) | |||
|
|
|||
| (defcustom counsel-yank-pop-ivy-height 5 | |||
There was a problem hiding this comment.
Maybe counsel-yank-pop-height would be clear enough?
counsel.el
Outdated
| (defcustom counsel-yank-pop-ivy-height 5 | ||
| "The `ivy-height' of `counsel-yank-pop'." | ||
| :group 'ivy | ||
| :type 'number) |
There was a problem hiding this comment.
This should be integer instead of number.
|
Thanks. |
There was a problem hiding this comment.
Currently the height is hardcoded to 5.
There was a problem hiding this comment.
Currently the height is hardcoded to 5.
WDYM? AFAICT it currently defaults to 5:
Lines 4591 to 4593 in 20d78ae
Which means you should be able to customise it like so:
(with-eval-after-load 'counsel
(ivy-configure #'counsel-yank-pop :height (round float-pi)))
There was a problem hiding this comment.
That's exactly what I mean. It's hardcoded, while not an option like counsel-yank-pop-height in this PR. I don't think users like to customize with ivy-configure.
There was a problem hiding this comment.
It's hardcoded
Well, hardcoded implies that it can't be changed, but...
while not an option like
counsel-yank-pop-heightin this PR
...I agree that simply loading counsel.el should not overwrite a manually modified ivy-height-alist like it currently does.
But at least ivy-configure does not modify ivy-height-alist if the user has customised it via the Customize interface, e.g. via customize-set-variable.
I don't think users like to customize with
ivy-configure.
I don't either, in fact I think the way it's currently used is a terrible idea that breaks several Emacs conventions and user expectations. But I suspect that ship has largely sailed, unless someone is willing to work together with @abo-abo on #2442 and related issues (I lack both the time and interest to).
Either way, this is something that would preferably be discussed in an issue or PR, not in a commit comments section. Thanks.
There was a problem hiding this comment.
Well, hardcoded implies that it can't be changed, but...
In fact, in Emacs everything can be changed easily, but...
BTW, I found this post: https://www.gitmemory.com/issue/abo-abo/swiper/2854/826066579.
Thanks anyway!
From #1362