Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-character action keys #1394

Closed
wants to merge 1 commit into from

Conversation

@ericdanan
Copy link
Contributor

commented Jan 4, 2018

This is a simple modification to ivy-read-action to support action keys with more than one character.

Note that such keys are already supported if ivy-hydra is loaded, because hydra supports them out of the box. So with this PR, multi-character action keys can be set whether ivy-hydra is loaded or not.

Of course one should not set an action's key to be a prefix of another action's key. Otherwise, if ivy-hydra is loaded then hydra will throw an error, and if it not loaded then the action with the prefix key will be called before one has a chance to complete the other action's key.

I did some testing and did not find any issue.

Let me know if you would like me to change some things.

Thanks.

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Jan 4, 2018

Thanks.

@ericdanan ericdanan deleted the ericdanan:multikey branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.