Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-locate-action-extern): Refactor #1401

Conversation

@NicolasPetton
Copy link
Contributor

commented Jan 8, 2018

Use start-process-shell-command which already calls call-process with
shell-file-name.

counsel.el (counsel-locate-action-extern): Refactor
Use start-process-shell-command which already calls call-process with
shell-file-name.

@abo-abo abo-abo closed this in 3a5a79d Jan 8, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Jan 8, 2018

Thanks.

abo-abo added a commit that referenced this pull request Sep 19, 2018
counsel.el: Fix xdg-open under Ubuntu for counsel-locate-action-extern
`start-process-shell-command` doesn't seem to wait for
`counsel-locate-action-extern` to finish under Ubuntu. [Gist to
reproduce the
issue](https://gist.github.com/yiufung/38be4c3a6832334f36f2441550cf0b12).

Related
discussion: ([#1](https://askubuntu.com/questions/646631/emacs-doesnot-work-with-xdg-open),
[#2](https://emacs.stackexchange.com/questions/19344/why-does-xdg-open-not-work-in-eshell),
[#3](http://emacs.1067599.n8.nabble.com/emacs-and-xdg-open-td106892.html))
suggests to:

1. Set `process-connection-type` as nil temporarily
2. Called with `setsid -w` to wait for the process to finish.

To avoid interfering with other platforms and applications, I adopted
the latter approach which uses `lsb_release` to check distribution
type with fall back as `xdg-open`. Currently only check for Ubuntu,
and to be extended in the future.

Re #863
Re #1401
Fixes #1759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.