New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swiper.el (swiper--ivy) Add integration with evil s expressions #1406
Conversation
I.e. searching for apple with swiper and then running `:s//orange/g` will replace all apples on the line with oranges as expected. Evil uses the last value of `isearch-string' for this completion.
Minor nit-picking: is it necessary to have the comment on three different lines?
Thanks. I adjusted your commit a bit. I'm pretty sure |
Looking back at why I had that in, I originally had this on some advice to Thanks again for your wonderful work! |
@YourFin the code which does this for evil-mode's evil-search module is here, in I would suggest you move the newly added code in (when (and (bound-and-true-p evil-mode) (eq evil-search-module 'isearch))
(setq isearch-string (substring-no-properties ivy-text))) As a result, all the code dealing with evil's search integration (be it Cheers! |
@edkolev Thanks, please check if this change is what you had in mind. |
@abo-abo at least for evil, Although, I'm not super sure how |
@abo-abo I just created a PR which but wraps the new code in a The PR also removes the comment about s-expressions since that means a totally different thing. In this scenario, it's referred to vim's |
I.e. searching for apple with swiper and then running
:s//orange/g
will replace all apples on the line with oranges asexpected. Evil uses the value of `isearch-string' for this
completion, hence it's inclusion.