Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexp-quote characters in ivy--regex-fuzzy #1435

Closed
wants to merge 1 commit into from

Conversation

@aaronjensen
Copy link
Contributor

commented Feb 7, 2018

This greatly improves performance when searching large code bases for things like .env.foo.

Regexp-quote characters in ivy--regex-fuzzy
This greatly improves performance when searching large code bases for things
like `.env.foo`.
@aaronjensen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2018

This could probably be applied to regex-plus as well, since " " serves as wildcard.

@abo-abo abo-abo closed this in d368aa7 Feb 7, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Feb 7, 2018

Thanks. The change makes sense for fuzzy matching, because . is almost a no-op there.

I want to keep regex-plus the way it is, applying . there actually makes sense, e.g. p.p will match pip and pop.

@aaronjensen aaronjensen deleted the aaronjensen:fuzzy-quote branch Feb 8, 2018

@aaronjensen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2018

Sounds good, I'm sure the perf isn't as bad there any way and one could probably escape the . if they needed to. Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.