Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el: Fold case during index recomputation #1447

Closed
wants to merge 1 commit into from

Conversation

@basil-conto
Copy link
Collaborator

commented Feb 9, 2018

Changelog

(ivy-case-fold-search-default): Use sensible default based on built-in user options search-upper-case and case-fold-search (see (emacs) Lax Search). Reduce special value always to t. Improve documentation.
(ivy-toggle-case-fold): Adapt documentation.
(ivy--case-fold-p, ivy--case-fold-string=): New convenience defuns.
(ivy-partial, ivy-completion-in-region, ivy--filter)
(ivy--recompute-index): Use them, also when recomputing index.

Motivation

  1. make plain
  2. C-hi
  3. memacs

Before

before

After

after

ivy.el: Fold case during index recomputation
(ivy-case-fold-search-default): Use sensible default based on
built-in user options search-upper-case and case-fold-search.
Reduce special value 'always' to 't'.  Improve documentation.
(ivy-toggle-case-fold): Adapt documentation.
(ivy--case-fold-p, ivy--case-fold-string=): New convenience defuns.
(ivy-partial, ivy-completion-in-region, ivy--filter)
(ivy--recompute-index): Use them, also when recomputing index.

Fixes #1447.

@basil-conto basil-conto force-pushed the basil-conto:blc/case-fold branch to 34e549a Feb 9, 2018

@abo-abo abo-abo closed this in 928d464 Feb 9, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Feb 9, 2018

Thanks.

basil-conto added a commit to basil-conto/swiper that referenced this pull request Feb 9, 2018
swiper.el: Use new defun ivy--case-fold-p
(swiper--add-overlays, swiper-all-function):
Use ivy--case-fold-p introduced in abo-abo#1447.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.