Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el: Fold case during index recomputation #1447

Closed
wants to merge 1 commit into from

Conversation

basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Feb 9, 2018

Changelog

(ivy-case-fold-search-default): Use sensible default based on built-in user options search-upper-case and case-fold-search (see (emacs) Lax Search). Reduce special value always to t. Improve documentation.
(ivy-toggle-case-fold): Adapt documentation.
(ivy--case-fold-p, ivy--case-fold-string=): New convenience defuns.
(ivy-partial, ivy-completion-in-region, ivy--filter)
(ivy--recompute-index): Use them, also when recomputing index.

Motivation

  1. make plain
  2. C-hi
  3. memacs

Before

before

After

after

(ivy-case-fold-search-default): Use sensible default based on
built-in user options search-upper-case and case-fold-search.
Reduce special value 'always' to 't'.  Improve documentation.
(ivy-toggle-case-fold): Adapt documentation.
(ivy--case-fold-p, ivy--case-fold-string=): New convenience defuns.
(ivy-partial, ivy-completion-in-region, ivy--filter)
(ivy--recompute-index): Use them, also when recomputing index.

Fixes abo-abo#1447.
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Feb 9, 2018

Thanks.

basil-conto added a commit to basil-conto/swiper that referenced this issue Feb 9, 2018
(swiper--add-overlays, swiper-all-function):
Use ivy--case-fold-p introduced in abo-abo#1447.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants