New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some docstring typos #1448
fix some docstring typos #1448
Conversation
LGTM. |
Actually, I would reword the commit message as "Fix some docstring typos". |
should I amend the git commit ? |
did I amend the git commit string properly ? |
I'm not the owner, so I can't force you, but FWIW I think the word "propose" makes no sense in a commit message. The commit was either merged, or it wasn't. It either fixed the typos, or it didn't. :) |
sorry, I will remove propose then |
@jeis2497052 I'm talking about the message of your git commit 6a0d1fd, not the GitHub PR title. |
got it, just amended |
Thanks, and sorry for the pedantry. :) |
I just want to contribute as I like using swiper and each repo has some nuance regarding PR. |
Sorry, I didn't mean to deter you (I'm not even a maintainer here!). My comment was only intended as a friendly and constructive suggestion to make the life of In general, though, the "nuances" of different FOSS projects aren't completely unjustified. Successfully maintaining these projects is very hard work and so maintainers often set up guidelines for a certain quality standard and for consistency which will make their life easier. See also https://windsooon.github.io/2017/11/23/Why%20we%20never%20thank%20open%20source%20maintainers/. Anyway, thanks for catching these typos (one of which I'm responsible for)! |
last thing I want is to contribute to additional work for any maintainer. I suppose I could have read commits to guess a little better. I have happy for follow your guidelines. Good link regarding the life of a maintainer. I can't image it. |
Thanks. I really should run |
no worries, I am the worst speller and live by ispell :-) |
are these OK?