Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiper.el: modify isearch-string only when evil-search-module is isearch #1452

Closed
wants to merge 1 commit into from

Conversation

@edkolev
Copy link
Contributor

commented Feb 12, 2018

Refs #1406

@edkolev

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2018

Please let me know if I can improve the PR. I was considering using an if instead of 2 whens, but I settled on the 2 whens. Let me know if I should change that.

A bit more details about this change - #1406 (comment)

@dieggsy

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2018

@edkolev a lot of isearch internally uses isearch-string. Should we consider adding this regardless of evil, or is it intentionally left out otherwise?

@edkolev

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2018

The way I see it, this PR (and the one ref-ed above) try to improve swiper integration with evil. I'd consider swiper integration with isearch in general out of the scope of this PR.

Also, isn't swiper an alternative to isearch, maybe it doesn't make a lot of sense to integrate them?

@edkolev edkolev force-pushed the edkolev:evil-search-module-isearch branch to 027280e Feb 13, 2018

@abo-abo abo-abo closed this in b5948f2 Feb 13, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Feb 13, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.