Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ivy-insert-org-entity. #1459

Closed
wants to merge 1 commit into from

Conversation

@jkitchin
Copy link
Contributor

commented Feb 15, 2018

This function provides an ivy frontend to adding org-entities as org, latex, html, ascii, utf-8 or Latin-1 characters. This would fulfill issue #1220.

This cleanly compiles and passes the tests. I don't think it adds any issues to checkdoc.

(defvar org-entities-user)

;;;###autoload
(defun ivy-insert-org-entity ()

This comment has been minimized.

Copy link
@basil-conto

basil-conto Feb 15, 2018

Collaborator

This should probably read counsel-org-insert-entity or counsel-org-entity and have its own ;;** heading like the other surrounding counsel-org-* commands.

"Insert an org-entity using ivy."
(interactive)
(ivy-read "Entity: " (cl-loop for element in (append org-entities org-entities-user)
when (not (stringp element))

This comment has been minimized.

Copy link
@basil-conto

basil-conto Feb 15, 2018

Collaborator

Please respect the project's indent-tabs-mode setting of nil.

@abo-abo abo-abo closed this in 0315b84 Feb 15, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Feb 15, 2018

Thanks. I renamed it to counsel-org-entity, since that's the common prefix for counsel.el.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.