Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other-frame actions for some find-file variants #1510

Closed
wants to merge 3 commits into from

Conversation

@tarsius
Copy link
Contributor

commented Mar 27, 2018

The last commit adds a other-frame as well as a other-window action to counsel-find-library. Emacs doesn't define find-library-other-{frame,window} so this is done using two lambdas. If you would rather add proper commands, you could copy them from my (very old) fwb-cmds library

@tarsius

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2018

Of course there are many more commands that could use an other-frame action. How do you feel about adding such actions where it makes sense? Might distract users who never use these actions, so maybe an option would be in order?

If you don't want to do this then I won't insist. I just figured it was worth a shot.

@abo-abo abo-abo closed this in aaf6419 Mar 27, 2018

abo-abo added a commit that referenced this pull request Mar 27, 2018
@abo-abo

This comment has been minimized.

Copy link
Owner

commented Mar 27, 2018

Thanks.

Of course there are many more commands that could use an other-frame action. How do you feel about adding such actions where it makes sense?

Sounds good.

Might distract users who never use these actions, so maybe an option would be in order?

Sounds good as well, I almost never use frames. On the other hand, the extra complexity might not be worth it; and the "freed-up" f wouldn't really be usable for something else anyway, since the toggle would override it if used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.