Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable to set :dynamic-collection on ivy-completing-read. #1524

Closed
wants to merge 1 commit into from

Conversation

@amol-mandhane
Copy link
Contributor

commented Apr 7, 2018

Some functions with completing-read require :dynamic-collection t so that the collection function is run again. Helm and Ido have these options which the functions can override using (let ...). This commit adds a similar option to Ivy.

Add variable to set :dynamic-collection on ivy-completing-read.
Some functions with completing-read require :dynamic-collection t so that the collection function is run again. Helm and Ido have these options which the functions can override using (let ...). This commit adds a similar option to Ivy.
@amol-mandhane

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2018

Ping.

Is this PR acceptable? This feature bridges gaps between configuration options between different frameworks and makes it easy to create generic tools.

Also, this is a no-op change by default. So this shouldn't change any existing behavior unless user explicitly changes the flag variable.

@abo-abo abo-abo closed this in cd2aab0 Apr 20, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Apr 20, 2018

Merged, thanks for the reminder:)

@basil-conto

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2018

@amol-mandhane Can you please provide some sample usage of this flag?

I tried setting it to t, but then programmed completion (e.g. Info-complete-menu-item) fails because the collection function is called with a single, rather than three, arguments:

swiper/ivy.el

Lines 1913 to 1914 in 7df7ab6

(dynamic-collection
(setq coll (funcall collection ivy-text)))

Is this what you were referring to when you said "This is breaking some of the existing functionality" in #1556?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.