Improve counsel-M-x-transformer key lookup #1534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Issue
counsel-M-x-transformer
unconditionally replaces C-x6 with F2 in the key description, without checking that the latter is still a valid binding.Recipe
make plain
2C-command
Performance
Compared to the incumbent
counsel-M-x-transformer
, the final version in this PR is up to twice as fast and never slower, regardless of C-x6 replacement. Thekey-description
->kbd
round trip, by contrast, is up to twice as slow as the incumbent. I think this justifies the only slight increase in algorithmic complexity.