Expand documentation of ivy-on-del-error-function #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* doc/ivy.org (Defcustoms): Fix typos and clarify documentation of ivy-on-del-error-function. * ivy.el (ivy-on-del-error-function): Clarify docstring and custom :type. (ivy-backward-delete-char): Clarify docstring. Refer to delete-backward-char, rather than its alias.
As of recently [1: 495963cfaf], the byte-compiler warns about defvaraliases appearing after their corresponding variable. [1: 495963cfaf]: 2018-04-20 17:22:47 -0400 * lisp/emacs-lisp/bytecomp.el (byte-compile-file-form-defvar-function): https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=495963cfaf535646350051f47c085b84319572f0 * counsel.el (counsel-org-headline-display-style) (counsel-org-headline-path-separator) (counsel-org-headline-display-tags) (counsel-org-headline-display-todo): Move varaliases before their vars. * ivy.el (ivy-backward-delete-char): Call delete-backward-char interactively, forwarding prefix-arg. This warning was not emitted when its alias backward-delete-char was called instead.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
doc/ivy.org(Defcustoms):Fix typos and clarify documentation of
ivy-on-del-error-function.ivy.el(ivy-on-del-error-function):Clarify docstring and custom
:type.(
ivy-backward-delete-char): Clarify docstring.Refer to
delete-backward-char, rather than its alias.The second commit pacifies the byte-compiler and explains the nature of its warnings.