Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand documentation of ivy-on-del-error-function #1535

Merged
merged 2 commits into from Apr 23, 2018

Conversation

basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Apr 23, 2018

  • doc/ivy.org (Defcustoms):
    Fix typos and clarify documentation of ivy-on-del-error-function.
  • ivy.el (ivy-on-del-error-function):
    Clarify docstring and custom :type.
    (ivy-backward-delete-char): Clarify docstring.
    Refer to delete-backward-char, rather than its alias.

The second commit pacifies the byte-compiler and explains the nature of its warnings.

basil-conto added 2 commits Apr 23, 2018
* doc/ivy.org (Defcustoms):
Fix typos and clarify documentation of ivy-on-del-error-function.
* ivy.el (ivy-on-del-error-function):
Clarify docstring and custom :type.
(ivy-backward-delete-char): Clarify docstring.
Refer to delete-backward-char, rather than its alias.
As of recently [1: 495963cfaf], the byte-compiler warns about
defvaraliases appearing after their corresponding variable.

[1: 495963cfaf]: 2018-04-20 17:22:47 -0400
  * lisp/emacs-lisp/bytecomp.el (byte-compile-file-form-defvar-function):
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=495963cfaf535646350051f47c085b84319572f0

* counsel.el (counsel-org-headline-display-style)
(counsel-org-headline-path-separator)
(counsel-org-headline-display-tags)
(counsel-org-headline-display-todo):
Move varaliases before their vars.
* ivy.el (ivy-backward-delete-char): Call delete-backward-char
interactively, forwarding prefix-arg.  This warning was not emitted
when its alias backward-delete-char was called instead.
@abo-abo abo-abo merged commit 1348220 into abo-abo:master Apr 23, 2018
1 of 2 checks passed
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Apr 23, 2018

Thanks.

@basil-conto basil-conto deleted the blc/on-del branch Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants