Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around current-kill pitfalls #1539

Merged
merged 2 commits into from Apr 26, 2018

Conversation

@basil-conto
Copy link
Collaborator

commented Apr 25, 2018

Re: #1523
Cc: @DamienCassou

I've tried to make the commit and source comments descriptive, but please let me know if you have any questions or issues.

counsel.el: Housekeeping
(counsel-yank-pop-truncate-radius):
Relocate to counsel-yank-pop sections, where it belongs.
(counsel-org-headline-display-style): Reindent docstring.
(counsel-yank-pop-filter): Reword docstring.
@basil-conto

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 25, 2018

@abo-abo I assume counsel-yank-pop is not the only Ivy-backed command whose actions (counsel-yank-pop-action-remove) can, when repeated via ivy-dispatching-call, result in an empty collection. Is this so? Either way, is this a problem?

counsel.el: Work around current-kill pitfalls
(counsel--yank-pop-kills): Clarify docstring.  Don't fail if
kill-ring and result of interprogram-paste-function are both nil.
Remove obsolete ivy-cleanup-string filtering.
(counsel-yank-pop-action): Avoid unexpected additions to kill-ring.
(counsel-yank-pop-action-remove):
Remove redundant call to counsel--yank-pop-kills.
(counsel-yank-pop-action-rotate): Allow forced update of window
system selection even when yank pointer rotation is a no-op.
Remove unnecessary ivy-state-collection update.
Avoid unexpected additions to kill-ring.
(counsel-yank-pop): Remove redundant varbinds.

Re: #1523

@basil-conto basil-conto force-pushed the basil-conto:blc/pr-1523 branch to a9db41e Apr 25, 2018

@basil-conto

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 25, 2018

Note that this PR does not address bug#31097 and bug#31209, and shouldn't need to, IMO.

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Apr 26, 2018

I assume counsel-yank-pop is not the only Ivy-backed command whose actions (counsel-yank-pop-action-remove) can, when repeated via ivy-dispatching-call, result in an empty collection. Is this so?

Could be. You can also kill almost all your buffers with ivy-switch-buffer.

Either way, is this a problem?

I don't think so.

@abo-abo abo-abo merged commit a9db41e into abo-abo:master Apr 26, 2018

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Copy link
Owner

commented Apr 26, 2018

Thanks.

@DamienCassou

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2018

Thank you very much!

@basil-conto basil-conto deleted the basil-conto:blc/pr-1523 branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.