Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve Swiper minibuffer highlighting #1551
It is actually not suboptimal, but rather entirely wrong - the improved substring highlighting in the After screenshot is only applied the first time around; any repeated invocation of
Coincidentally, I started trying to fix regex-ignore-order highlighting in swiper recently. I was looking at the buffer highlighting first instead of the minibuffer highlighting. For highlighting, swiper seems to only support regex builders that return a single regex. In particular
Edit: just saw your comment in #1550 (comment)
Should I pause my effort and see what happens with this PR, or do you think they are unrelated? I'd like to contribute to making regex-ignore-order a first class regex option. I've noticed some other worrisome things like ignore-order does not make use of
I opened this PR because I thought I had stumbled across a quick fix to minibuffer highlighting at least, but I was wrong. I'm not actually familiar with how everything interoperates and I don't currently have much free time, so please don't pause your efforts because of me.
As a fellow user, I look forward to seeing the fruit of your efforts. Thanks for working on this.