Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve counsel-ibuffer #1569

Merged
merged 3 commits into from May 14, 2018

Conversation

@basil-conto
Copy link
Collaborator

commented May 14, 2018

Commits:

  1. Ensure ibuffer does not mess with the user's window/frame configuration by telling it to reuse the selected window.
  2. Try to simplify logic. Stop referring to "vanilla" Ibuffer, which incorrectly suggests it is new and pristine.
  3. Reorder surrounding counsel.el sections more consistently.

Cc: @fabacino

basil-conto added 3 commits May 13, 2018
counsel.el: Avoid popping up Ibuffer window
(counsel-ibuffer--get-buffers): Avoid window/frame configuration
changes when creating a new Ibuffer.
counsel.el: Touch-up Ibuffer functions
(counsel-ibuffer, counsel-ibuffer--get-buffers): Simplify logic.
(counsel-ibuffer-visit-buffer-other-window): Improve docstring.
(counsel-ibuffer-visit-vanilla-ibuffer): Ditto.
Rename to counsel-ibuffer-visit-ibuffer.
counsel.el: Reorder final sections
Move Ibuffer section before counsel-mode.
Untangle counsel-switch-to-shell-buffer from counsel-mode.
@basil-conto

This comment has been minimized.

Copy link
Collaborator Author

commented May 14, 2018

By the way, is the obsolete function alias overkill?

@abo-abo abo-abo merged commit 36f55f5 into abo-abo:master May 14, 2018

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Copy link
Owner

commented May 14, 2018

Thanks.

By the way, is the obsolete function alias overkill?

I think so. The key bindings did not change, and functions weren't callable with M-x.

basil-conto added a commit to basil-conto/swiper that referenced this pull request May 14, 2018
counsel.el: Revert recent obsolete function alias
(counsel-ibuffer-visit-ibuffer):
counsel-ibuffer-visit-vanilla-ibuffer was deemed internal enough not
to warrant an obsolete function alias.

Re: abo-abo#1569
@basil-conto

This comment has been minimized.

Copy link
Collaborator Author

commented May 14, 2018

By the way, is the obsolete function alias overkill?

I think so. The key bindings did not change, and functions weren't callable with M-x.

OK, I've added a commit removing it to #1570.

@basil-conto basil-conto deleted the basil-conto:blc/ibuffer branch May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.