Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upivy.el: Drop preselected candidate after input #1573
Conversation
raxod502
force-pushed the
raxod502:feat/override-preselected-on-input
branch
May 15, 2018
basil-conto
reviewed
May 15, 2018
ivy.el
Outdated
| ;; If there was a preselected candidate, don't try to | ||
| ;; keep it selected even if the regexp still matches | ||
| ;; it. See issue #1563. See also `ivy--preselect-index', | ||
| ;; which this logic roughly mirrors. |
This comment has been minimized.
This comment has been minimized.
basil-conto
May 15, 2018
Collaborator
Nitpick: please honour the sentence-end-double-space setting in dir-locals-file.
basil-conto
reviewed
May 15, 2018
ivy.el
Outdated
| (and (stringp (ivy-state-preselect ivy-last)) | ||
| (string-match-p | ||
| (ivy-state-preselect ivy-last) | ||
| (ivy-state-current ivy-last))))) |
This comment has been minimized.
This comment has been minimized.
basil-conto
May 15, 2018
Collaborator
Nitpick: might be nice to bind ivy-state-preselect and ivy-state-current to reduce visual clutter (and avoid duplicate calls).
This comment has been minimized.
This comment has been minimized.
basil-conto
May 15, 2018
Collaborator
(Seeing as there are other calls to these accessors in the function as well.)
raxod502
force-pushed the
raxod502:feat/override-preselected-on-input
branch
May 15, 2018
This comment has been minimized.
This comment has been minimized.
|
@basil-conto Good ideas! I made the relevant changes. |
basil-conto
reviewed
May 15, 2018
ivy.el
Outdated
| ;; See issue #1563. See also `ivy--preselect-index', | ||
| ;; which this logic roughly mirrors. | ||
| (not (let ((preselect (ivy-state-preselect ivy-last)) | ||
| (current (ivy-state-current ivy-last))) |
This comment has been minimized.
This comment has been minimized.
basil-conto
May 15, 2018
•
Collaborator
Nitpick: Again, there are other parts of ivy--recompute-index which could make use of these bindings.
raxod502
force-pushed the
raxod502:feat/override-preselected-on-input
branch
to
01c2dda
May 21, 2018
This comment has been minimized.
This comment has been minimized.
|
@basil-conto Fixed, thanks. |
This comment has been minimized.
This comment has been minimized.
|
@abo-abo Any comments? |
abo-abo
closed this
in
0cf0e6d
Jul 3, 2018
This comment has been minimized.
This comment has been minimized.
|
Merged, thanks. |
raxod502
added a commit
to raxod502/prescient.el
that referenced
this pull request
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
raxod502 commentedMay 15, 2018
Suggested fix for #1563.