Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcounsel.el: Support amx in addition to smex #1585
Conversation
basil-conto
force-pushed the
basil-conto:blc/pr-1580
branch
May 22, 2018
This comment has been minimized.
This comment has been minimized.
|
Anything? :) |
This comment has been minimized.
This comment has been minimized.
I think @abo-abo has been busy/AFK these days; let's be patient. :) |
basil-conto
force-pushed the
basil-conto:blc/pr-1580
branch
to
bb9422b
Jun 6, 2018
This comment has been minimized.
This comment has been minimized.
I've been on vacation for 2 weeks. Got 62 unread issues/pull requests greeting me when I came back. Down to 30 unread ones by now:) |
abo-abo
closed this
in
4e3eaf4
Jun 7, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks all. |
This comment has been minimized.
This comment has been minimized.
Thanks, power to you. :) |
basil-conto
deleted the
basil-conto:blc/pr-1580
branch
Jun 7, 2018
This comment has been minimized.
This comment has been minimized.
|
Fantastic, thanks guys. Also, hope you enjoyed your holiday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
basil-conto commentedMay 22, 2018
(
counsel--M-x-externs): New function.(
counsel-M-x): Use it. Conditionally callamx-rankorsmex-rank, when available, from the action function.Borrowing heavily from and building on the work and suggestions of @Ergus in #1580.
Fixes #1557.