counsel.el: Support amx in addition to smex #1585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything? :) |
I think @abo-abo has been busy/AFK these days; let's be patient. :) |
(counsel--M-x-externs): New function. (counsel-M-x): Use it. Conditionally call amx-rank or smex-rank, when available, from the action function. Borrowing heavily from and building on the work and suggestions of Jimmy Aguilar Mena <kratsbinovish@gmail.com> (@Ergus) in abo-abo#1580. Fixes abo-abo#1557
I've been on vacation for 2 weeks. Got 62 unread issues/pull requests greeting me when I came back. Down to 30 unread ones by now:) |
|
Thanks all. |
Thanks, power to you. :) |
|
Fantastic, thanks guys. Also, hope you enjoyed your holiday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
(
counsel--M-x-externs): New function.(
counsel-M-x): Use it. Conditionally callamx-rankorsmex-rank, when available, from the action function.Borrowing heavily from and building on the work and suggestions of @Ergus in #1580.
Fixes #1557.