Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el: Support amx in addition to smex #1585

Closed
wants to merge 1 commit into from

Conversation

basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented May 22, 2018

(counsel--M-x-externs): New function.
(counsel-M-x): Use it. Conditionally call amx-rank or smex-rank, when available, from the action function.

Borrowing heavily from and building on the work and suggestions of @Ergus in #1580.

Fixes #1557.

@manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented May 28, 2018

Anything? :)

@basil-conto
Copy link
Collaborator Author

@basil-conto basil-conto commented May 28, 2018

Anything? :)

I think @abo-abo has been busy/AFK these days; let's be patient. :)

(counsel--M-x-externs): New function.
(counsel-M-x): Use it.  Conditionally call amx-rank or smex-rank,
when available, from the action function.

Borrowing heavily from and building on the work and suggestions of
Jimmy Aguilar Mena <kratsbinovish@gmail.com> (@Ergus) in abo-abo#1580.

Fixes abo-abo#1557
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 7, 2018

I think @abo-abo has been busy/AFK these days; let's be patient. :)

I've been on vacation for 2 weeks. Got 62 unread issues/pull requests greeting me when I came back. Down to 30 unread ones by now:)

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 7, 2018

Thanks all.

@basil-conto
Copy link
Collaborator Author

@basil-conto basil-conto commented Jun 7, 2018

I've been on vacation for 2 weeks. Got 62 unread issues/pull requests greeting me when I came back. Down to 30 unread ones by now:)

Thanks, power to you. :)

@basil-conto basil-conto deleted the blc/pr-1580 branch Jun 7, 2018
@manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented Jun 8, 2018

Fantastic, thanks guys.

Also, hope you enjoyed your holiday ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants