Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show docstring in counsel-set-variable if lv available #1595

Closed
wants to merge 1 commit into from

Conversation

justbur
Copy link
Contributor

@justbur justbur commented May 25, 2018

  • counsel.el (counsel-set-variable): Show variable docstring when lv is
    available

counsel.el Outdated
@@ -622,34 +622,43 @@ input corresponding to the chosen variable."
(counsel-variable-list)
:preselect (ivy-thing-at-point)
:history 'counsel-set-variable-history))))
(let (sym-type
(let ((doc (and (require 'cus-edit nil t)
Copy link
Collaborator

@basil-conto basil-conto May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not get away with just (require 'cus-edit) here?

* counsel.el (counsel-set-variable): Show variable docstring when lv is
  available
@justbur justbur force-pushed the docstring-set-variable branch from 5f1f485 to 724ab3f Compare May 28, 2018
@justbur
Copy link
Contributor Author

@justbur justbur commented May 28, 2018

Made the change requested by @basil-conto, and formatted the docstring as a comment, which I like a little better visually.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 7, 2018

Nice idea, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants