Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show docstring in counsel-set-variable if lv available #1595

Closed
wants to merge 1 commit into from

Conversation

@justbur
Copy link
Contributor

commented May 25, 2018

  • counsel.el (counsel-set-variable): Show variable docstring when lv is
    available
counsel.el Outdated
@@ -622,34 +622,43 @@ input corresponding to the chosen variable."
(counsel-variable-list)
:preselect (ivy-thing-at-point)
:history 'counsel-set-variable-history))))
(let (sym-type
(let ((doc (and (require 'cus-edit nil t)

This comment has been minimized.

Copy link
@basil-conto

basil-conto May 25, 2018

Collaborator

Can we not get away with just (require 'cus-edit) here?

Show docstring in counsel-set-variable if lv available
* counsel.el (counsel-set-variable): Show variable docstring when lv is
  available

@justbur justbur force-pushed the justbur:docstring-set-variable branch to 724ab3f May 28, 2018

@justbur

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2018

Made the change requested by @basil-conto, and formatted the docstring as a comment, which I like a little better visually.

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Jun 7, 2018

Nice idea, thanks.

@abo-abo abo-abo closed this in e3238cf Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.