Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Ivy yank commands #1604

Closed
wants to merge 5 commits into from
Closed

Conversation

basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented May 30, 2018

Commit summary:

  1. Address #1588. The question of whether a default key binding should be provided for ivy-yank-char still remains.
  2. Add a similar command for symbols (same question about key binding).
  3. Minor refactoring.
  4. Unconditionally allow all yank commands to continue yanking until EOL.
  5. Add optional prefix arguments to all yank commands.

Please see each commit message in turn for further details.

basil-conto added 5 commits May 30, 2018
ivy.el (ivy--yank-by): New function generalising old ivy-yank-word.
(ivy-yank-word): Use it.
(ivy-yank-char): New command.
swiper.el (swiper--update-input-ivy): Make exception for it.
doc/ivy.org (Key bindings that alter the minibuffer input):
Mention it.

Re: abo-abo#1588
ivy.el (ivy-yank-symbol): New command.
swiper.el (swiper--update-input-ivy): Make exception for it.
doc/ivy.org (Key bindings that alter the minibuffer input):
Mention it.
Wrap motion in unwind-protect to ensure point is restored in the
theoretical case that something goes wrong.  Specify FIXEDCASE and
LITERAL arguments to replace-regexp-in-string.
Previously, if FN (e.g. forward-word) moved point to the next line,
the yank would be "aborted" (i.e. original point would be restored
and no text would be inserted).  This change allows ivy--yank-by to
continue yanking as far as possible within the current line.
(ivy--yank-by): Clamp new position within original line bounds.
(ivy-yank-word, ivy-yank-symbol, ivy-yank-char):
Accept optional prefix argument.
@basil-conto
Copy link
Collaborator Author

@basil-conto basil-conto commented Jun 2, 2018

See also #1501.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 6, 2018

Thanks!

@basil-conto basil-conto deleted the blc/issue-1588 branch Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants