Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various counsel face touch-ups #1620

Closed
wants to merge 9 commits into from
Closed

Conversation

basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Jun 13, 2018

Please review each commit in turn. The first commit addresses #1619.

basil-conto added 9 commits Jun 14, 2018
(counsel--face-at-point): New function.
(counsel-describe-face, counsel-faces):
Use it to determine :preselect face.
(counsel-describe-face): Enable :require-match and :sort.
(counsel-faces): Reorder ivy-read args.
This collapses face aliases like describe-function.
(counsel-describe-face, counsel-faces): Use it.
(counsel-faces-history): Remove.
(counsel-faces-action-describe): Rename to...
(counsel-customize-face): ...this.
(counsel-customize-face-other-window): New function.

(counsel-describe-face-function): New user option, similar to
counsel-describe-function-function and
counsel-describe-variable-function.
(counsel-describe-face, counsel-faces): Use it as the default
:action.  Remove duplicate actions "d", "i", and "k".
Add counsel-customize-face-other-window as a new action "C".
Do not hard-code prompt format.
(counsel--faces-fmt, counsel-faces--sample-text): Remove.
(counsel--faces-format-function):
Use list-faces-sample-text instead of counsel-faces--sample-text.
Accept FORMAT argument analogous to counsel--faces-fmt and return
lambda suitable as ivy-format-function.
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 14, 2018

Thanks.

@basil-conto basil-conto deleted the blc/faces branch Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants