Skip to content

/swiper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various counsel face touch-ups #1620

Closed
wants to merge 9 commits into from

Conversation

@basil-conto
Copy link
Collaborator

commented Jun 13, 2018

Please review each commit in turn. The first commit addresses #1619.
@basil-conto basil-conto referenced this pull request Jun 13, 2018
Closed

@basil-conto basil-conto force-pushed the basil-conto:blc/faces branch Jun 13, 2018

basil-conto added 9 commits Jun 13, 2018
@basil-conto
counsel.el (counsel-describe-face): Set :caller 
Fixes #1619
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
bd2698f
@basil-conto
counsel.el (counsel-faces): Clarify docstring
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
24b2ab3
@basil-conto
counsel.el: Fix face preselects 
(counsel--face-at-point): New function.
(counsel-describe-face, counsel-faces):
Use it to determine :preselect face.
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
c007d2c
@basil-conto
counsel.el: Touch-up face function ivy-read args 
(counsel-describe-face): Enable :require-match and :sort.
(counsel-faces): Reorder ivy-read args.
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
52bd711
@basil-conto
counsel.el (counsel-faces): Autoload command
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
c4487a8
@basil-conto
counsel.el (counsel-describe-face): Use face-list 
This collapses face aliases like describe-function.
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
dee3cd7
@basil-conto
counsel.el: Use face-name-history 
(counsel-describe-face, counsel-faces): Use it.
(counsel-faces-history): Remove.
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
cc10dca
@basil-conto
counsel.el (counsel-faces): Simplify 
Do not hard-code prompt format.
(counsel--faces-fmt, counsel-faces--sample-text): Remove.
(counsel--faces-format-function):
Use list-faces-sample-text instead of counsel-faces--sample-text.
Accept FORMAT argument analogous to counsel--faces-fmt and return
lambda suitable as ivy-format-function.
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
Loading status checks…
4061c6f
@basil-conto
counsel.el: Make face describing more customizable 
(counsel-faces-action-describe): Rename to...
(counsel-customize-face): ...this.
(counsel-customize-face-other-window): New function.

(counsel-describe-face-function): New user option, similar to
counsel-describe-function-function and
counsel-describe-variable-function.
(counsel-describe-face, counsel-faces): Use it as the default
:action.  Remove duplicate actions "d", "i", and "k".
Add counsel-customize-face-other-window as a new action "C".
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
17ae0f5

@basil-conto basil-conto force-pushed the basil-conto:blc/faces branch to 4061c6f Jun 14, 2018

@abo-abo abo-abo closed this in 30d0081 Jun 14, 2018

@abo-abo

This comment has been minimized.

Sign in to view
Copy link
Owner

commented Jun 14, 2018

Thanks.

@basil-conto basil-conto deleted the basil-conto:blc/faces branch Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@basil-conto @abo-abo
You can’t perform that action at this time.