Various counsel face touch-ups #1620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(counsel--face-at-point): New function. (counsel-describe-face, counsel-faces): Use it to determine :preselect face.
(counsel-describe-face): Enable :require-match and :sort. (counsel-faces): Reorder ivy-read args.
This collapses face aliases like describe-function.
(counsel-describe-face, counsel-faces): Use it. (counsel-faces-history): Remove.
(counsel-faces-action-describe): Rename to... (counsel-customize-face): ...this. (counsel-customize-face-other-window): New function. (counsel-describe-face-function): New user option, similar to counsel-describe-function-function and counsel-describe-variable-function. (counsel-describe-face, counsel-faces): Use it as the default :action. Remove duplicate actions "d", "i", and "k". Add counsel-customize-face-other-window as a new action "C".
Do not hard-code prompt format. (counsel--faces-fmt, counsel-faces--sample-text): Remove. (counsel--faces-format-function): Use list-faces-sample-text instead of counsel-faces--sample-text. Accept FORMAT argument analogous to counsel--faces-fmt and return lambda suitable as ivy-format-function.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Please review each commit in turn. The first commit addresses #1619.