Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el: Reorganize headings #1625

Merged
merged 1 commit into from Jun 14, 2018

Conversation

@basil-conto
Copy link
Collaborator

commented Jun 14, 2018

(counsel-company, counsel-irony): Move to Completion at point.
(counsel-apropos, command-history, counsel-faces):
Move to Elisp symbols.
(counsel-bookmark, counsel-file-register): Move to Files.
(counsel-file-jump, counsel-dired-jump):
New subheadings split from File Jump and Dired Jump.

(Org): New heading.
(counsel-org-tag, counsel-org-file, counsel-org-entity)
(counsel-org-capture, counsel-org-agenda-headlines): Move here.

(Misc Emacs): Rename to Misc. Emacs.
(counsel-ibuffer, counsel-switch-to-shell-buffer)
(counsel-unicode-char, counsel-colors, counsel-colors-emacs)
(counsel-colors-web): Move here.

(Misc OS): Rename to Misc. OS.
(counsel-mode): Promote to top-level heading.

counsel.el: Reorganize headings
(counsel-company, counsel-irony): Move to Completion at point.
(counsel-apropos, command-history, counsel-faces):
Move to Elisp symbols.
(counsel-bookmark, counsel-file-register): Move to Files.
(counsel-file-jump, counsel-dired-jump):
New subheadings split from File Jump and Dired Jump.

(Org): New heading.
(counsel-org-tag, counsel-org-file, counsel-org-entity)
(counsel-org-capture, counsel-org-agenda-headlines): Move here.

(Misc Emacs): Rename to Misc. Emacs.
(counsel-ibuffer, counsel-switch-to-shell-buffer)
(counsel-unicode-char, counsel-colors, counsel-colors-emacs)
(counsel-colors-web): Move here.

(Misc OS): Rename to Misc. OS.
(counsel-mode): Promote to top-level heading.

@abo-abo abo-abo merged commit 62357fc into abo-abo:master Jun 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Copy link
Owner

commented Jun 14, 2018

Thanks. A minor impact of moving things around like this is probably a couple of merge conflicts in the existing PR. Another impact is on git blame. Still, it's nice to get things organized, I think it's a good change. But let's not do something like this too much)

@basil-conto

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 14, 2018

Agreed, I just thought things had gotten a bit too disorganised. It should now be easier to ensure new contributions are aptly placed/labelled.

Thanks.

@basil-conto basil-conto deleted the basil-conto:blc/headings branch Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.