Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project dependencies #1630

Closed
wants to merge 3 commits into from
Closed

Fix project dependencies #1630

wants to merge 3 commits into from

Conversation

basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Jun 15, 2018

Summary:

  • Remove etags and esh-util as top-level dependencies of Counsel.
  • Fix Emacs 24.4 usage of subr-x re: #1629.

Please see each commit for details.

basil-conto added 3 commits Jun 15, 2018
(counsel--push-xref-marker):
New function localizing etags/xref dependency.
(counsel--find-symbol): Use it.
(counsel-prompt-function-dir): Load esh-util on demand.
counsel.el (counsel-git-worktree-list, counsel-git-branch-list):
Let split-string do trimming, rather than doing it manually with
Emacs 24.4 string-trim-right.
doc/ivy-ox.el: Do not load subr-x during byte-code interpretation.
swiper.el (swiper-occur):
Remove subr-x runtime dependency and simplify.

Fixes abo-abo#1629
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 15, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants