Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project dependencies #1630

wants to merge 3 commits into from


Copy link

commented Jun 15, 2018


  • Remove etags and esh-util as top-level dependencies of Counsel.
  • Fix Emacs 24.4 usage of subr-x re: #1629.

Please see each commit for details.

basil-conto added 3 commits May 17, 2018
Fix subr-x usage
counsel.el (counsel-git-worktree-list, counsel-git-branch-list):
Let split-string do trimming, rather than doing it manually with
Emacs 24.4 string-trim-right.
doc/ivy-ox.el: Do not load subr-x during byte-code interpretation.
swiper.el (swiper-occur):
Remove subr-x runtime dependency and simplify.

Fixes #1629
counsel.el: Future-proof etags/xref dependency
New function localizing etags/xref dependency.
(counsel--find-symbol): Use it.
counsel.el: Remove top-level esh-util dependency
(counsel-prompt-function-dir): Load esh-util on demand.

@basil-conto basil-conto force-pushed the basil-conto:blc/deps branch to 92b5451 Jun 15, 2018

@abo-abo abo-abo closed this in 6f29394 Jun 15, 2018


This comment has been minimized.

Copy link

commented Jun 15, 2018


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.