Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUse compatibility shim for add-face-text-property #1635
Conversation
basil-conto
force-pushed the
basil-conto:blc/add-face
branch
to
7a8fdc3
Jun 18, 2018
basil-conto
referenced
this pull request
Jun 18, 2018
basil-conto
force-pushed the
basil-conto:blc/add-face
branch
from
7a8fdc3
to
b8c5190
Jun 19, 2018
abo-abo
merged commit b8c5190
into
abo-abo:master
Jun 19, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks. |
This comment has been minimized.
This comment has been minimized.
Looks good to me. Removing the extra description would have also been fine. |
basil-conto
deleted the
basil-conto:blc/add-face
branch
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
basil-conto commentedJun 18, 2018
•
edited
ivy.el(ivy--add-face): Minor simplification.(
ivy-add-face-text-property): Expand arglist to that ofadd-face-text-property, but with the order of the last two args flipped. Move compatibility check from runtime to evaluation time. Usefont-lock-prepend-text-propertyinstead offont-lock-append-text-propertywhen applicable.(
ivy-append-face): Replacefont-lock-append-text-propertywithivy-add-face-text-property.(
ivy-display-style):doc/ivy.org(Installation, Defcustoms): Mention Emacs 24.4 instead of 24.5.counsel.el(counsel-git-grep-transformer):ivy-overlay.el(ivy-display-function-overlay): Replaceadd-face-text-propertywithivy-add-face-text-property.Re: #1634
Before merging this PR I would like to make sure that the docstring and implementation of
ivy--add-faceare clear and correct w.r.t. the discussion in #1634.