Use compatibility shim for add-face-text-property #1635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
ivy.el
(ivy--add-face
): Minor simplification.(
ivy-add-face-text-property
): Expand arglist to that ofadd-face-text-property
, but with the order of the last two args flipped. Move compatibility check from runtime to evaluation time. Usefont-lock-prepend-text-property
instead offont-lock-append-text-property
when applicable.(
ivy-append-face
): Replacefont-lock-append-text-property
withivy-add-face-text-property
.(
ivy-display-style
):doc/ivy.org
(Installation, Defcustoms): Mention Emacs 24.4 instead of 24.5.counsel.el
(counsel-git-grep-transformer
):ivy-overlay.el
(ivy-display-function-overlay
): Replaceadd-face-text-property
withivy-add-face-text-property
.Re: #1634
Before merging this PR I would like to make sure that the docstring and implementation of
ivy--add-face
are clear and correct w.r.t. the discussion in #1634.