* counsel.el (counsel-set-variable): Add prefix arg behavior. #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter out vars without custom-type properties.
basil-conto
reviewed
Jun 29, 2018
| (lambda (var) | ||
| (get (intern var) 'custom-type)) | ||
| vars) | ||
| vars)) |
There was a problem hiding this comment.
AKA
(ivy-read "Set variable: " (counsel-variable-list)
:predicate (and current-prefix-arg
(lambda (varname)
(get (intern varname) 'custom-type)))
:history 'counsel-set-variable-history
:preselect (ivy-thing-at-point)
:sort t
:caller 'counsel-set-variable)(Any reason :sort and :caller weren't already specified?)
There was a problem hiding this comment.
@basil-conto That version is nicer but it doesn't work for me.
There was a problem hiding this comment.
@justbur Can you please elaborate?
There was a problem hiding this comment.
@basil-conto Yes, sorry. With your version a prefix arg does not seem to have any affect on the list of candidates, while my initial version did eliminate candidates in my tests. I'm not sure why
There was a problem hiding this comment.
Oh, seems to be #1158.
|
Thanks. |
basil-conto
added a commit
to basil-conto/swiper
that referenced
this issue
Aug 7, 2018
counsel.el (counsel-set-variable): Use custom-variable-p instead of inspecting the custom-type property, which is only set when a defcustom has a :type. Re: abo-abo#1643
abo-abo
pushed a commit
that referenced
this issue
Aug 8, 2018
counsel.el (counsel-set-variable): Use custom-variable-p instead of inspecting the custom-type property, which is only set when a defcustom has a :type. Re: #1643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Filter out vars without custom-type properties.