Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-org-tag): Fix for Org 9 #1656

Merged
merged 2 commits into from Jul 9, 2018

Conversation

basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Jul 7, 2018

Org 9, which shipped with Emacs 26, introduced a new buffer-local variable org-current-tag-alist which incorporates the values of org-tag-alist and org-tag-persistent-alist.

Fixes #1654.

P.S. Is the org-setting-tags binding needed?

basil-conto added 2 commits Jul 7, 2018
Org 9, which shipped with Emacs 26, introduced a new buffer-local
variable org-current-tag-alist which incorporates the values of
org-tag-alist and org-tag-persistent-alist.

Fixes abo-abo#1654
@abo-abo abo-abo merged commit e9de468 into abo-abo:master Jul 9, 2018
1 of 2 checks passed
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 9, 2018

Thanks.

@basil-conto
Copy link
Collaborator Author

@basil-conto basil-conto commented Jul 9, 2018

Thanks @abo-abo.

P.S. Is the org-setting-tags binding needed?

Any insights on this?

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 9, 2018

Looks like it's not needed after all. It was copied from org-set-tags, but it seems it only has effect on org-todo.

@basil-conto basil-conto deleted the blc/issue-1654 branch Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants