Skip to content

/swiper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-org-tag): Fix for Org 9 #1656

Merged
merged 2 commits into from Jul 9, 2018

Conversation

@basil-conto
Copy link
Collaborator

commented Jul 7, 2018

Org 9, which shipped with Emacs 26, introduced a new buffer-local variable org-current-tag-alist which incorporates the values of org-tag-alist and org-tag-persistent-alist.

Fixes #1654.

P.S. Is the org-setting-tags binding needed?
basil-conto added 2 commits Jul 7, 2018
@basil-conto
counsel.el (counsel-org-tag): Fix for Org 9 
Org 9, which shipped with Emacs 26, introduced a new buffer-local
variable org-current-tag-alist which incorporates the values of
org-tag-alist and org-tag-persistent-alist.

Fixes #1654
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
98826c2
@basil-conto
counsel.el (counsel-org-tag): Minor aesthetics
Verified
This commit was signed with a verified signature.
basil-conto Basil L. Contovounesios
GPG key ID: 205AB54A5D5D8CFF Learn about signing commits
Loading status checks…
e9de468

@abo-abo abo-abo merged commit e9de468 into abo-abo:master Jul 9, 2018
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Sign in to view
Copy link
Owner

commented Jul 9, 2018

Thanks.
@basil-conto

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Jul 9, 2018

Thanks @abo-abo.

P.S. Is the org-setting-tags binding needed?

Any insights on this?
@abo-abo

This comment has been minimized.

Sign in to view
Copy link
Owner

commented Jul 9, 2018

Looks like it's not needed after all. It was copied from org-set-tags, but it seems it only has effect on org-todo.

@basil-conto basil-conto deleted the basil-conto:blc/issue-1654 branch Jul 9, 2018

abo-abo added a commit that referenced this pull request Jul 10, 2018
@abo-abo
counsel.el (counsel-org-tag): No need to bind org-setting-tags 
Re #1656
Loading status checks…
f2e80ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@basil-conto @abo-abo
You can’t perform that action at this time.