Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counsel move/delete file #1671

Merged
merged 2 commits into from Jul 18, 2018
Merged

Conversation

DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented Jul 18, 2018

No description provided.

@DamienCassou DamienCassou changed the title Counsel move delete file Counsel move/delete file Jul 18, 2018
@abo-abo abo-abo merged commit 944c20d into abo-abo:master Jul 18, 2018
1 of 2 checks passed
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 18, 2018

Thanks. I did have some reservations about giving destructive commands default key bindings. But if they're not bound they're not useful; and it's an extra config for the users. And probably the chance of the hand slipping and typing M-o k is low.

@DamienCassou DamienCassou deleted the counsel-move-delete-file branch Jul 18, 2018
@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Jul 19, 2018

Thanks for adding this. I wonder, though, why these features depend on Dired. Any reason why we can't just use rename-file, delete-file, delete-directory, etc.?

@DamienCassou
Copy link
Contributor Author

@DamienCassou DamienCassou commented Jul 19, 2018

@basil-conto I thought using dired functions would free us from reimplementing basic features such as rename of file-visiting buffers and recursive deletion of directories with optional prompt... FWIW, helm also uses dired functions to do the same.

@basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Jul 19, 2018

I thought using dired functions would free us from reimplementing basic features such as rename of file-visiting buffers and recursive deletion of directories with optional prompt...

OK, fair enough. Thanks for explaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants