Generalize counsel-outline to handle major modes and display styles - cont'd #1684
Conversation
counsel.el
Outdated
| adequate or optimal, these variables can be rebound locally in | ||
| the major mode hook. Replacements are provided for some such | ||
| modes. To set them up, add this to your init file:" | ||
| This command's behavior can be customized based on the current buffer's major mode. See variable `counsel-outline-settings'." |
There was a problem hiding this comment.
Needs more filling! :)
There was a problem hiding this comment.
Not sure what you mean. I agree the sentence is not very informative, but on the other hand I didn't want to duplicate the information of counsel-outline-settings's docstring.
So I just removed the sentence. This actually seems in line with many counsel commands that have short docstrings not mentioning the corresponding custom variables.
But of course if you have suggestions, @abo-abo will make the decision.
counsel.el
Outdated
| ;; `\end{document}', in which case we simply return that. | ||
| (if (and (assoc (match-string 1) (if (boundp 'LaTeX-section-list) | ||
| LaTeX-section-list | ||
| latex-section-alist)) ; section macro |
There was a problem hiding this comment.
How about:
(or (bound-and-true-p LaTeX-section-list)
(bound-and-true-p latex-section-alist)))This removes the need for (defvar LaTeX-section-list) or (defvar latex-section-alist) and makes the function a tiny bit less mode/package-dependent (not that this is particularly important).
Also allow to set them in `counsel-outline-settings', and update default org-mode setting to reflect `counsel-org-goto'.
|
In the last batch of 4 commits, the first and fourth follow @basil-conto 's comments. The second one add The third one transforms the I don't plan to push more commits for now, unless you suggest me to do so. |
|
Thanks. |
Sorry @ericdanan, I didn't see your reply to my comment. I was referring to what Emacs calls filling, by which all I meant was that the docstring line was too long and should be wrapped at ~65 columns, as is customary in Elisp. |
|
I see, thanks for clarifying.
Basil L. Contovounesios writes:
… Not sure what you mean.
Sorry @ericdanan, I didn't see your reply to my comment. I was referring to what Emacs calls filling, by which all I meant was that the docstring line was
too long and should be wrapped at ~65 columns, as is customary in Elisp.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
| If verbatim, the face used in the buffer is applied. For simple | ||
| headlines in org-mode buffers, this is usually the same as org | ||
| except that it depends on how much of the buffer has been | ||
| completely loaded. If your buffer exceeds a certain size, |
There was a problem hiding this comment.
I know the wording wasn't touched by this PR, but since I'm working on improving these docs, I'd like to clarify: instead of "loaded", should this say "fontified" or similar instead? Because I don't understand how a buffer can be partially loaded.
Re #1681