Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch-up Counsel variable & function completion #1707

Closed
wants to merge 3 commits into from

Conversation

basil-conto
Copy link
Collaborator

@basil-conto basil-conto commented Aug 7, 2018

Please see each commit in turn.

Cc: @justbur

basil-conto added 3 commits Aug 7, 2018
(counsel--variable-p): New predicate.
(counsel-describe-variable, counsel-set-variable): Use it.
(counsel-variable-list): Remove, replacing with counsel--variable-p.
counsel.el (counsel-set-variable):
Use custom-variable-p instead of inspecting the custom-type
property, which is only set when a defcustom has a :type.

Re: abo-abo#1643
counsel.el (counsel-describe-function):
Describe also unbound but documented function symbols.
@manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented Aug 8, 2018

Just chiming in to thank @basil-conto for the immense work. ivy/counsel/swiper are so central to my daily workflow it's just awesome to see such valuable efforts on improving on them.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 8, 2018

Thanks.

@basil-conto
Copy link
Collaborator Author

@basil-conto basil-conto commented Aug 8, 2018

@manuel-uberti Thanks, but I'm mostly just doing minor refactors/prettifications, which I guess is my way of becoming more familiar with the codebase. :)

The real thanks are due to @abo-abo and the many other valuable contributors who brought this and related projects to fruition, and who continue to maintain them.

@basil-conto basil-conto deleted the blc/counsel-syms branch Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants