Skip to content

Allow % in prompt string#171

Merged
abo-abo merged 1 commit intoabo-abo:masterfrom
egh:fix/hash_in_prompt
Jul 13, 2015
Merged

Allow % in prompt string#171
abo-abo merged 1 commit intoabo-abo:masterfrom
egh:fix/hash_in_prompt

Conversation

@egh
Copy link
Copy Markdown
Contributor

@egh egh commented Jul 12, 2015

  • quote % when passing prompt from ivy-completing-read to ivy-read
  • add documentation in ivy-read that all % should be quoted

- quote % when passing prompt from ivy-completing-read to ivy-read
- add documentation in ivy-read that all % should be quoted
@abo-abo
Copy link
Copy Markdown
Owner

abo-abo commented Jul 12, 2015

Wouldn't this transform %d into %%d?

@egh
Copy link
Copy Markdown
Contributor Author

egh commented Jul 12, 2015

Yes, I think this is the correct thing to do. Otherwise ivy-completing-read is not a drop-in replacement for completing-read. If users want to use %d in a prompt they can call ivy-read.

@abo-abo abo-abo merged commit de2e819 into abo-abo:master Jul 13, 2015
@abo-abo
Copy link
Copy Markdown
Owner

abo-abo commented Jul 13, 2015

Ah, I didn't notice it was in completing-read. Thanks a lot, merged.

@egh
Copy link
Copy Markdown
Contributor Author

egh commented Jul 13, 2015

Thank you! And thanks for ivy, I've been finding it far more intuitive than helm or ido.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants