New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow % in prompt string #171

Merged
merged 1 commit into from Jul 13, 2015

Conversation

Projects
None yet
2 participants
@egh
Contributor

egh commented Jul 12, 2015

  • quote % when passing prompt from ivy-completing-read to ivy-read
  • add documentation in ivy-read that all % should be quoted
Allow % in prompt string
- quote % when passing prompt from ivy-completing-read to ivy-read
- add documentation in ivy-read that all % should be quoted
@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Jul 12, 2015

Owner

Wouldn't this transform %d into %%d?

Owner

abo-abo commented Jul 12, 2015

Wouldn't this transform %d into %%d?

@egh

This comment has been minimized.

Show comment
Hide comment
@egh

egh Jul 12, 2015

Contributor

Yes, I think this is the correct thing to do. Otherwise ivy-completing-read is not a drop-in replacement for completing-read. If users want to use %d in a prompt they can call ivy-read.

Contributor

egh commented Jul 12, 2015

Yes, I think this is the correct thing to do. Otherwise ivy-completing-read is not a drop-in replacement for completing-read. If users want to use %d in a prompt they can call ivy-read.

@abo-abo abo-abo merged commit de2e819 into abo-abo:master Jul 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Jul 13, 2015

Owner

Ah, I didn't notice it was in completing-read. Thanks a lot, merged.

Owner

abo-abo commented Jul 13, 2015

Ah, I didn't notice it was in completing-read. Thanks a lot, merged.

@egh

This comment has been minimized.

Show comment
Hide comment
@egh

egh Jul 13, 2015

Contributor

Thank you! And thanks for ivy, I've been finding it far more intuitive than helm or ido.

Contributor

egh commented Jul 13, 2015

Thank you! And thanks for ivy, I've been finding it far more intuitive than helm or ido.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment